Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use @npmcli/template-oss #433

Merged
merged 1 commit into from
Mar 25, 2022
Merged

chore: use @npmcli/template-oss #433

merged 1 commit into from
Mar 25, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Feb 26, 2022

This adds @npmcli/template-oss to manage GitHub Actions, linting, and
other chores.

This surfaced a few bugs which I opted to fix in separate issues:

Closes #146
Closes #421
Closes #426
Closes #401
Closes #358

lukekarrys added a commit that referenced this pull request Feb 26, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*`
on either side causing a decrease in performance when used on range
strings with a lot of spaces. Since the result of the split is
immediately trimmed, we can just split on the string instead.
@lukekarrys
Copy link
Contributor Author

This fails linting and CodeQL which should be fixed by #432 and #434. I think this should be merged first before those are considered since this will allow for CI to run properly on those PRs.

@lukekarrys lukekarrys mentioned this pull request Feb 27, 2022
@lukekarrys lukekarrys force-pushed the lk/update branch 2 times, most recently from f75a170 to 8a3aa0e Compare March 25, 2022 18:12
lukekarrys added a commit that referenced this pull request Mar 25, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*`
on either side causing a decrease in performance when used on range
strings with a lot of spaces. Since the result of the split is
immediately trimmed, we can just split on the string instead.
@lukekarrys lukekarrys force-pushed the lk/update branch 2 times, most recently from 23dbd47 to 8ed4b9d Compare March 25, 2022 18:51
lukekarrys added a commit that referenced this pull request Mar 25, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*`
on either side causing a decrease in performance when used on range
strings with a lot of spaces. Since the result of the split is
immediately trimmed, we can just split on the string instead.
lukekarrys added a commit that referenced this pull request Mar 25, 2022
Found in #433, the regex used to split ranges on `||` was padded by `\s*`
on either side causing a decrease in performance when used on range
strings with a lot of spaces. Since the result of the split is
immediately trimmed, we can just split on the string instead.
@lukekarrys lukekarrys force-pushed the lk/update branch 4 times, most recently from 8b4da5f to b9515aa Compare March 25, 2022 21:40
This adds `@npmcli/template-oss` to manage GitHub Actions, linting, and
other chores.

This surfaced a few bugs which I opted to fix in separate issues:

- #432
- #434
@ljharb
Copy link

ljharb commented Apr 7, 2022

This was a breaking change, since it dropped a number of node versions that are included in >= 10 but not the latest semver range; see #447.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Changelog Standard?
2 participants